Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle negative patterns better when specified in pnpm-workspaces #19983

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #19225
Fixes #19981
Fixes #19619

@AgentEnder AgentEnder requested a review from a team as a code owner November 1, 2023 18:32
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 11:19pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any docs changes here. Not sure why I was tagged.

@AgentEnder AgentEnder force-pushed the fix/negative-workspaces-patterns branch from 58c21d3 to c9f7654 Compare January 28, 2024 23:18
@JamesHenry JamesHenry closed this Jan 29, 2024
@AgentEnder AgentEnder reopened this Jan 29, 2024
@AgentEnder AgentEnder self-assigned this Jan 29, 2024
@AgentEnder AgentEnder merged commit 2753565 into nrwl:master Feb 2, 2024
7 checks passed
@AgentEnder AgentEnder deleted the fix/negative-workspaces-patterns branch February 2, 2024 15:31
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
FrozenPandaz pushed a commit that referenced this pull request Feb 3, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants