Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure plugin testing uses correct pm for install #20061

Merged
merged 1 commit into from Nov 23, 2023

Conversation

meeroslav
Copy link
Contributor

When running tests in a temp folder where a workspace has been generated with different package manager than the root one, the ensureNxPackage and newNxProject will fail.

The runNxNewCommand always generates workspace with npm which might not be matching the root package manager. The failure has been detected on nx-react-workspace with Yarn v4

Current Behavior

runPackageManagerInstall will use the package manager detected from the root of the repo regardless what package manager is set in the folder where we are running the command.

Expected Behavior

runPackageManagerInstall should detect the package manager from the folder where it's being run.

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Nov 6, 2023
@meeroslav meeroslav requested a review from a team as a code owner November 6, 2023 11:17
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 11:33am

@meeroslav meeroslav added the scope: core core nx functionality label Nov 6, 2023
@AgentEnder AgentEnder merged commit 5cd938a into nrwl:master Nov 23, 2023
7 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants