New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): generate correctly when --js is used for module federation host/remote #20119
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f9f5922. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Hello, it would be great if someone can review my pr and give me some feedback. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2d24ef8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
f90b882
to
f4c2853
Compare
cd6410d
to
5f825e2
Compare
32cad88
to
40dabcc
Compare
40dabcc
to
c9c8dbc
Compare
c7abf22
to
d39896f
Compare
d39896f
to
ecb592e
Compare
ecb592e
to
5fbc77b
Compare
5fbc77b
to
6db5194
Compare
6db5194
to
1831a80
Compare
1831a80
to
43fed36
Compare
43fed36
to
2d24ef8
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Module federation for @nx/react does not work correctly in combination with the
js
option. When executed in spits out a combination of js and ts files. If you try to start up the project it will complain about a missingbootstrap
file.Expected Behavior
Module federation should work with @nx/react and the
js
optionRelated Issue(s)
Fixes #20066
Changes
options.js = true