Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): generate correctly when --js is used for module federation host/remote #20119

Merged
merged 7 commits into from Feb 12, 2024

Conversation

Remcoman
Copy link
Contributor

@Remcoman Remcoman commented Nov 8, 2023

Current Behavior

Module federation for @nx/react does not work correctly in combination with the js option. When executed in spits out a combination of js and ts files. If you try to start up the project it will complain about a missing bootstrap file.

Expected Behavior

Module federation should work with @nx/react and the js option

Related Issue(s)

Fixes #20066

Changes

  • Output js files when options.js = true
  • Add tests for js=true and js=false option
  • Also made sure that tests for typescriptConfiguration=true and typescriptConfiguration=false are only focused on the configuration files

@Remcoman Remcoman requested a review from a team as a code owner November 8, 2023 11:03
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 12, 2024 8:08pm

@Remcoman
Copy link
Contributor Author

Hello, it would be great if someone can review my pr and give me some feedback.

@jaysoo jaysoo self-assigned this Jan 29, 2024
@jaysoo jaysoo changed the title Fix js module federation for @nx/react fix(react): generate correctly when --js is used for module federation host/remote Jan 29, 2024
@jaysoo jaysoo force-pushed the fix-js-module-federation branch 3 times, most recently from f90b882 to f4c2853 Compare January 29, 2024 22:14
@jaysoo jaysoo enabled auto-merge (squash) January 29, 2024 22:15
@jaysoo jaysoo force-pushed the fix-js-module-federation branch 2 times, most recently from cd6410d to 5f825e2 Compare January 30, 2024 16:41
@Remcoman Remcoman requested a review from a team as a code owner January 30, 2024 16:41
@jaysoo jaysoo force-pushed the fix-js-module-federation branch 2 times, most recently from 32cad88 to 40dabcc Compare January 30, 2024 17:06
@Remcoman Remcoman requested a review from a team as a code owner February 7, 2024 19:33
@jaysoo jaysoo merged commit c87884a into nrwl:master Feb 12, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module federation using js is broken
3 participants