feat(core): don't clear NX_BASE or NX_HEAD #20125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f765c3b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
do-not-delete-NX_BASE-NX_HEAD
branch
from
f765c3b
to
469d67d
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 469d67d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jan 29, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit f9009e9)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When I try to access the
NX_BASEenvironment variable that I set in CI from a local executor it returnsundefinedExpected Behavior
I can access the
NX_BASEvalue that I set in CI within a local executorRelated Issue(s)
The behavior was added in #10523 however it is unclear why it was necessary. As far as I can tell Nx does not write to these environment variables. The nearby comment says that they are being reset in case Nx is called within Nx however I precisely do not want them reset so that I can call Nx within Nx and re-use the same base and head
This is tangentially related to this discord question