Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add option for @nx/dependency-checks to update workspace dependencies using local file paths #20157

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 9, 2023

This PR adds useLocalPathsForWorkspaceDependencies option to @nx/dependency-checks lint rule so that when using --fix, it can use a local path (e.g. file:../foobar) rather than the current * value.

Also, when useLocalPathsForWorkspaceDependencies is false or undefined, the value is read from the source/committed package.json file of the dependency rather than using *. This way users can use the committed versions if that is how they manage releases, or set the version to * if desired.

Another benefit is that committed versions are now also checked to ensure version ranges match their dependencies' versions.

Current Behavior

Expected Behavior

Related Issue(s)

Related #19989

@jaysoo jaysoo requested review from a team as code owners November 9, 2023 18:01
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 30, 2024 0:37am

@BenSawary
Copy link

@jaysoo your build is broken. Can you please check this out, to get your feature with the next Nx release :)

@mandarini mandarini merged commit f6d2dcc into nrwl:master Feb 2, 2024
6 checks passed
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants