Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): import SupportedStyles type from correct path #20239

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

miluoshi
Copy link
Contributor

Current Behavior

Having incorrect import path for SupportedStyles type. There's no packages/react/typings/index.d.ts barrel file that would reexport style types.

Expected Behavior

tsc doesn't throw error when typechecking schema

@miluoshi miluoshi requested a review from a team as a code owner November 14, 2023 15:42
@miluoshi miluoshi requested a review from jaysoo November 14, 2023 15:42
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 3:43pm

@uufukttas
Copy link

Hey @miluoshi!
When will you merge this pr?
I have errors for this problem on my project? Can you prioritize?

Thank you. :)

@miluoshi
Copy link
Contributor Author

miluoshi commented Jan 26, 2024

Hey @uufukttas, I'm not a maintainer, I've just volunteered to fix the issue :)

Someone from Nx team (@jaysoo ?) has to review it before it can be merged.

@mandarini mandarini merged commit 1d10023 into nrwl:master Jan 30, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants