feat(angular): convert module-federation-dev-server to executor #20252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team and
leosvelperez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c58d138. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
feat/convert-mf-dev-server-to-executor
branch
from
10d6811
to
359a515
Compare
Coly010
force-pushed
the
feat/convert-mf-dev-server-to-executor
branch
from
359a515
to
50615ae
Compare
Coly010
force-pushed
the
feat/convert-mf-dev-server-to-executor
branch
from
50615ae
to
377d268
Compare
leosvelperez
approved these changes
Nov 22, 2023
jaysoo
approved these changes
Nov 22, 2023
ndcunningham
approved these changes
Nov 22, 2023
Coly010
force-pushed
the
feat/convert-mf-dev-server-to-executor
branch
from
377d268
to
c58d138
Compare
isaacplmann
approved these changes
Nov 30, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our
module-federation-dev-serveris currently an Angular CLI Builder.This means we are restricted to using
scheduleTargetwhen running Dev Remotes.This has the knock-on effect that all dev remotes will be built sequentially.
Consequently, by it being a builder, we have less control over how to handle or improve this feature over time.
Expected Behavior
The
module-federation-dev-servershould be an Nx Exectuor.The benefits:
module-federation-dev-serverexecutorsRelated Issue(s)
Fixes #