Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): @nx/web:file-server should not error on destructuring null #20318

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

The daemon watcher sometimes returns an error, and when doing so the second arg is null. This results in an error:

TypeError: Cannot destructure property 'changedFiles' of 'object null' as it is null.
    at /Users/dnichols2/Documents/Repos/webplatform.ui/node_modules/@nx/web/src/executors/file-server/file-server.impl.js:81:24
    at Socket.<anonymous> (/Users/dnichols2/Documents/Repos/webplatform.ui/node_modules/nx/src/daemon/client/client.js:121:17)
    at Socket.emit (node:events:517:28)
    at Pipe.<anonymous> (node:net:350:12)

Expected Behavior

There is not an error on the restructuring logic, preserving the original error message.

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner November 17, 2023 17:38
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 5:39pm

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AgentEnder AgentEnder merged commit 2a5d541 into nrwl:master Nov 17, 2023
6 checks passed
@AgentEnder AgentEnder deleted the fix/web-file-server-destructure-null branch November 17, 2023 20:30
FrozenPandaz pushed a commit that referenced this pull request Nov 17, 2023
FrozenPandaz pushed a commit that referenced this pull request Nov 17, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants