-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devkit): improving error handeling read target options #20336
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c92c10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Sorry @AgentEnder I accidentally pushed 700+ file changes in my previous PR and reverted that commit concluding to it closing my PR |
Catching a wrong target given in the project.json for component testing. closed nrwl#20251
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e39b1f1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
(cherry picked from commit 946c6a7)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Catching a wrong target given in the project.json for component testing.
closed #20251
Current Behavior
When running a Cypress component test with a wrong target it will error with an unclear error:
Expected Behavior
With this fix, it should catch when the
executor
is not found and throw a clear error saying that the target is not found on the project. This makes it clearer what the error is aboutRelated Issue(s)
Fixes #20251
(This is a re-opening of This PR since something went wring formatting and it closed it)