Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remote url port depends on serve target #20417

Merged
merged 1 commit into from Nov 27, 2023

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

with multiple remotes, the remote url always return port 4201

when serve with ssr, it runs serve target on the remote rather than 'serve-server' :

so the port of the remote url should be taken on the serve target options

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner November 24, 2023 20:44
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:26pm

@xiongemi xiongemi merged commit 21e952f into nrwl:master Nov 27, 2023
6 checks passed
Copy link

github-actions bot commented Dec 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants