Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nestjs lib generator pass skipPackageJson flag to js lib generator #20442

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

ckaeslin
Copy link
Contributor

Current Behavior

Using the nestjs library generator with skipPackageJson: true adds ts-node to package.json.

Expected Behavior

skipPackageJson: true in nestjs lib generator should not add anything to package.json

Related Issue(s)

Fixes #

Pass the skipPackageJson flag to the js lib generator so that package.json is not adjusted if the flag is set to true in the nest lib generator.

@ckaeslin ckaeslin requested a review from a team as a code owner November 28, 2023 07:55
@ckaeslin ckaeslin requested a review from jaysoo November 28, 2023 07:55
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 15, 2023 8:18am

@ckaeslin
Copy link
Contributor Author

@jaysoo this tiny PR would help us to fix our generator, is there a chance to get this merged in the near future?

@mandarini mandarini self-assigned this Jan 30, 2024
@jaysoo jaysoo merged commit 8b371b0 into nrwl:master Jan 30, 2024
5 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants