-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(js): allow inlined libs without imports #20649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a928c8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
a1941c3
to
a928c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, thanks
a928c8e
to
fb4bb8a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fb4bb8a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
(cherry picked from commit 169a3f5)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Our team has been working on some internal projects that typically get built with inlined libs. We came up with a generator to create our projects with presets including
external
, but since they're new projects they haven't imported any libs (yet!).Current Behavior
When the
external
option for the@nx/js:tsc
executor is set toall
ornone
but the project doesn't import any libs, the build fails.Expected Behavior
Build the project successfully.