Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-native): upgrade react native to 0.73 #20896

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Dec 22, 2023

Current Behavior

  • This PR upgrade react-native to 0.73.1
  • need to wait for the expo to publish 50
  • also need to wait for @expo/webpack-config to support expo 50

Expected Behavior

  • react native 0.73 is going to support symlink as default, no need to manually symlink the node_modules folder
  • now for the react native app, developers can run generator @nx/react-native:web-configuration to create a web app version of the native app using either webpack or vite as bundler
  • now change the storybook to use the default react storybook configuration, so the storybook would be viewed on the web, with no more version conflict
  • also, since web configuration is supported, now developers can also use cypress or playwright to e2e tests their apps

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 31, 2024 7:41pm

@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 73cf56a to fc4e8d6 Compare December 22, 2023 16:21
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from fc4e8d6 to d5f7cbf Compare December 30, 2023 06:29
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from d5f7cbf to 82a678f Compare January 1, 2024 02:06
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 82a678f to 9bc1c0c Compare January 2, 2024 22:42
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 9bc1c0c to 370d809 Compare January 3, 2024 02:28
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 370d809 to 1de7e86 Compare January 3, 2024 04:23
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 1de7e86 to 9da6b78 Compare January 10, 2024 20:50
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 9da6b78 to f600ebd Compare January 17, 2024 05:26
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from f600ebd to ba72f07 Compare January 17, 2024 07:00
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from ba72f07 to fa16136 Compare January 17, 2024 18:19
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from fa16136 to 76d4c41 Compare January 18, 2024 07:06
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 76d4c41 to 941b98a Compare January 22, 2024 02:59
@xiongemi xiongemi force-pushed the feature/upgrade-react-native-73 branch from 941b98a to fe71edb Compare January 23, 2024 18:17
@xiongemi xiongemi reopened this Jan 29, 2024
@xiongemi xiongemi mentioned this pull request Jan 31, 2024
@xiongemi xiongemi merged commit 65e86ea into nrwl:master Jan 31, 2024
6 checks passed
Copy link

github-actions bot commented Feb 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants