fix(webpack): correctly handle data URIs with escaped quotes in style… #20988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2f4ad80. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
andreasmoller25
force-pushed
the
master
branch
from
c5b0fe3
to
cd30d6f
Compare
andreasmoller25
force-pushed
the
master
branch
from
cd30d6f
to
2f4ad80
Compare
|
@jaysoo Would be really grateful if this fix could be included in the next nx-release. Best regards: |
mandarini
approved these changes
Jan 31, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a copy of the fix already done in the angular-cli repository: angular/angular-cli#23691
Current Behavior
Double quoted url() in css arguments are parsed incorrectly
Expected Behavior
Double quoted url() in css arguments are parsed correctly
Related Issue(s)
No issue in repo, fixes same copied code as described in angular-cli repository angular/angular-cli#23680