Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): publicPath and rebaseRootRelative #20992

Merged
merged 4 commits into from
May 9, 2024

Conversation

wzc0415
Copy link
Contributor

@wzc0415 wzc0415 commented Jan 4, 2024

Current Behavior

can not configure webpack publicPath with NX option.

Expected Behavior

make the publicPath work with postcssCliResources.

Related Issue(s)

Fixes #

@wzc0415 wzc0415 requested review from a team as code owners January 4, 2024 06:52
@wzc0415 wzc0415 requested review from jaysoo and juristr January 4, 2024 06:52
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 9, 2024 9:55am

@Coly010 Coly010 changed the title Fix(webpack): publicPath and rebaseRootRelative. fix(webpack): publicPath and rebaseRootRelative May 8, 2024
@Coly010 Coly010 merged commit 8f25ade into nrwl:master May 9, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request May 9, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
 can not configure webpack publicPath with NX option.
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
 make the publicPath work with postcssCliResources.
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

---------

Co-authored-by: Colum Ferry <cferry09@gmail.com>
(cherry picked from commit 8f25ade)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants