Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Add support for mjs next config file #21007

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jan 4, 2024

Current Behavior

Currently, PCV3 with Next.js only supports .js and .cjs next config files.

Expected Behavior

With this change we now also support .mjs next config file.

Related Issue(s)

Fixes #

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Jan 4, 2024
@ndcunningham ndcunningham self-assigned this Jan 4, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner January 4, 2024 18:21
@ndcunningham ndcunningham requested a review from xiongemi January 4, 2024 18:21
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 7:19pm

@ndcunningham ndcunningham force-pushed the fix/next-pcv3-mjs-support branch from 86a7922 to 54b062c Compare January 4, 2024 19:19
@ndcunningham ndcunningham merged commit a04eb74 into nrwl:master Jan 5, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/next-pcv3-mjs-support branch January 5, 2024 15:40
isaacplmann pushed a commit to isaacplmann/nx that referenced this pull request Jan 8, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants