fix(testing): fix config references to js files #21018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In the project.json there is a reference to cypress.config.ts. This should be cypress.config.js instead. This is currently hardcoded here but should be dynamic based on extension: https://github.com/nrwl/nx/blob/a04eb7420365334ae6cfcbc9d93fa6121f2090e6/packages/cypress/src/generators/configuration/configuration.ts#L249C75-L249C75
the nxE2EPreset contains a hardcoded reference to ${basePath}/support/e2e.ts (https://github.com/nrwl/nx/blob/a04eb7420365334ae6cfcbc9d93fa6121f2090e6/packages/cypress/plugins/cypress-preset.ts#L104C5-L104C47). This should become: ${basePath}/support/e2e.{js,jsx,ts,tsx}
Expected Behavior
NX Cypress should use the correct js/ts files based on the
--js
optionRelated Issue(s)
Fixes #21017