Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): fix config references to js files #21018

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Remcoman
Copy link
Contributor

@Remcoman Remcoman commented Jan 5, 2024

Current Behavior

  1. In the project.json there is a reference to cypress.config.ts. This should be cypress.config.js instead. This is currently hardcoded here but should be dynamic based on extension: https://github.com/nrwl/nx/blob/a04eb7420365334ae6cfcbc9d93fa6121f2090e6/packages/cypress/src/generators/configuration/configuration.ts#L249C75-L249C75

  2. the nxE2EPreset contains a hardcoded reference to ${basePath}/support/e2e.ts (https://github.com/nrwl/nx/blob/a04eb7420365334ae6cfcbc9d93fa6121f2090e6/packages/cypress/plugins/cypress-preset.ts#L104C5-L104C47). This should become: ${basePath}/support/e2e.{js,jsx,ts,tsx}

Expected Behavior

NX Cypress should use the correct js/ts files based on the --js option

Related Issue(s)

Fixes #21017

@Remcoman Remcoman requested a review from a team as a code owner January 5, 2024 10:19
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 8, 2024 8:08am

@mandarini mandarini changed the title Fix config references to js files for Cypress tests fix(testing): fix config references to js files Jan 31, 2024
@mandarini mandarini merged commit e4b1ab6 into nrwl:master Jan 31, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
Copy link

github-actions bot commented Feb 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Cypress config and supportFile when using js.
3 participants