fix(nest): exclude react-specific packages when generating nx nest monorepo #21153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d85eadb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
mihailgolban
force-pushed
the
update-ui-framework-based-on-options-is-nest
branch
3 times, most recently
from
5564fc6
to
7eb9460
Compare
mihailgolban
force-pushed
the
update-ui-framework-based-on-options-is-nest
branch
from
7eb9460
to
c5bd637
Compare
mandarini
approved these changes
Jan 31, 2024
jaysoo
approved these changes
Jan 31, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
This pull request addresses the issue where React-specific packages were being installed unnecessarily when generating a new project with the Nest preset. The proposed changes modify the application generator to exclude the following packages:
These packages are not applicable to NestJS projects and are typically associated with React monorepos.
Expected Behavior
Only the necessary packages for NestJS should be installed, excluding the unnecessary React-related packages.
Related Issue(s)
Fixes #21152