feat(core): add support for loading .ts files using ESM #21268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6d26115. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
reviewed
Jan 22, 2024
AgentEnder
reviewed
Jan 22, 2024
jaysoo
force-pushed
the
ts_esm_config
branch
2 times, most recently
from
3b41064
to
b56ce6d
Compare
FrozenPandaz
approved these changes
Jan 30, 2024
jaysoo
force-pushed
the
ts_esm_config
branch
3 times, most recently
from
de46274
to
27b369c
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use ESM with
.tsfiles. The strategy is as follows:module.registerfunction to programmatically register ESM loaders (introduced in Node 20.6.0), fork the CLI again with the--experimental-loader ts-node/esmoption.registerTsProjectfunction will also register the ESM loader.Fixes
@nx/playwright/pluginto be able to use ESM inplaywright.config.tsfile. Now, Epic Stack doesnx initproperly. :)Performance impact
Based on local testing, reloading the process for Node < 20.6 is adding ~10ms to the Nx CLI. If this is a problem we can remove the logic from
init-local.tsand ask users to update their Node version.