feat(core): improve nx connect success message #21295
Merged
+45
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c851ac5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
bcabanes
approved these changes
Jan 24, 2024
FrozenPandaz
requested changes
Jan 24, 2024
packages/nx/src/nx-cloud/generators/connect-to-nx-cloud/connect-to-nx-cloud.ts
Outdated
Show resolved
Hide resolved
meeroslav
requested review from
StalkAltan,
rarmatei,
a team,
vsavkin,
jaysoo and
JamesHenry
as code owners
FrozenPandaz
added
PR status: do not merge
FrozenPandaz
approved these changes
Jan 30, 2024
| @@ -54,15 +50,10 @@ export async function connectToNxCloudCommand(): Promise<boolean> { | |||
| const nxJson = readNxJson(); | |||
| if (isNxCloudUsed(nxJson)) { | |||
| output.log({ | |||
| title: '✅ This workspace is already connected to Nx Cloud.', | |||
| title: '✔ This workspace has already Nx Cloud set up', | |||
There was a problem hiding this comment.
Suggested change
| title: '✔ This workspace has already Nx Cloud set up', | |
| title: '✔ This workspace already has Nx Cloud set up', |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Nx Cloud connect success message to point to root of Nx Cloud app, so that the users can benefit from the new GitHub automated workflow.
Related Issue(s)
Fixes #