feat(angular): add generator to convert targets to use the esbuild-based application executor #21333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8c2432. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
angular/convert-to-application-executor-generator
branch
4 times, most recently
from
020f4b5
to
4a7f91e
Compare
leosvelperez
requested review from
FrozenPandaz,
jaysoo,
AgentEnder and
a team
as code owners
Coly010
approved these changes
Jan 30, 2024
meeroslav
approved these changes
Jan 30, 2024
…sed application executor
leosvelperez
force-pushed
the
angular/convert-to-application-executor-generator
branch
from
4a7f91e
to
c8c2432
Compare
leosvelperez
deleted the
angular/convert-to-application-executor-generator
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
convert-to-application-executorgenerator that allows converting a project or all projects using one of the@angular-devkit/build-angular:browser,@angular-devkit/build-angular:browser-esbuild,@nx/angular:browserand@nx/angular:browser-esbuildexecutors to use the@nx/angular:applicationexecutor or the@angular-devkit/build-angular:applicationbuilder. If the converted target is using one of the@nx/angularexecutors, the@nx/angular:applicationexecutor will be used. Otherwise, the@angular-devkit/build-angular:applicationbuilder will be used.Some restrictions apply and the project(s) won't be converted if any of the following conditions is met:
deployUrloptionAdditionally, the generator can only be run on workspaces using Angular v17.0.0 or greater.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #