fix(misc): prevent ts-node from reading tsconfig when registering transpiler #21381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b85fd8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
Jan 29, 2024
AgentEnder
approved these changes
Jan 30, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When registering the
ts-nodetranspiler, we provide the compiler options that were already read from the tsconfig file. Then,ts-nodeloads again the tsconfig file to read the same compiler options already provided.Expected Behavior
When registering the
ts-nodetranspiler we preventts-nodefrom rereading the tsconfig file. The already provided compiler options are all that's needed.Note: we should do something similar when registering the SWC transpiler (don't set the
SWC_NODE_PROJECTenv var), but there's currently an issue swc-project/swc-node#716 where provided compiler options are just plainly ignored and the config is always read. While that issue was already addressed, the fix hasn't been released yet: swc-project/swc-node#750. Even when it gets released, we probably can't rely on that unless we check which version it's installed in the workspace, because it might not contain the fix.Related Issue(s)
Fixes #