Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Add missing support swc for custom server #21401

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

When you generate a custom server with --swc enabled it uses @nx/jsc:tsc as the executor for building the server

Expected Behavior

  1. It should use @nx/js:swc for building the custom server.
  2. It should install swc dependencies if missing.
  3. It should generate a .swcrc file

Related Issue(s)

Fixes #21217

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Jan 29, 2024
@ndcunningham ndcunningham self-assigned this Jan 29, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner January 29, 2024 20:18
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:48pm

@ndcunningham ndcunningham force-pushed the fix/next-support-swc-custom-server branch from 7331f14 to 3aa81cf Compare January 29, 2024 20:28
@ndcunningham ndcunningham force-pushed the fix/next-support-swc-custom-server branch from 3aa81cf to 1059af0 Compare January 29, 2024 20:48
@ndcunningham ndcunningham merged commit d31b951 into master Jan 29, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/next-support-swc-custom-server branch January 29, 2024 21:13
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Next] @nx/next:custom-server with --compiler=swc still use @nx/js:tsc as executor
2 participants