fix(module-federation): ensure the static remotes env var is used for task hashing #21390 #21414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25964a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
approved these changes
Jan 30, 2024
Coly010
changed the title
packages/angular/src/migrations/update-18-0-0/add-mf-env-var-to-target-defaults.ts
Show resolved
Hide resolved
Coly010
force-pushed
the
mf/fix-env-var-caching
branch
from
6c460fe
to
25964a2
Compare
jaysoo
approved these changes
Jan 31, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a remote is built and served via the
module-federation-dev-serveran env var is used point to a single file server, allowing for increased performance benefits locally.However, this env var isn't taken into consideration when the task hash is calculated, leading to false positives.
Expected Behavior
Ensure the env var is added to the executor inputs in target defaults in nx.json.
Related Issue(s)
Fixes #21390