Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): restore rules to match previous @typescript-eslint/recommended #21424

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Jan 30, 2024

Current Behavior

All of @typescript-eslint/stylisticwere enabled in 4700df6 but this was not an appropriate solution because it has created too much of a difference in a minor release.

Expected Behavior

17.3 linting matches 17.2 linting

Related Issue(s)

Fixes #21412

@JamesHenry JamesHenry requested a review from a team as a code owner January 30, 2024 15:16
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 30, 2024 4:36pm

@JamesHenry JamesHenry enabled auto-merge (squash) January 30, 2024 15:16
@JamesHenry JamesHenry changed the title fix(linter): disable @typescript-eslint/stylistic rules that previously weren't on fix(linter): restore rules to match previous @typescript-eslint/recommended Jan 30, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) January 30, 2024 15:53
@JamesHenry JamesHenry merged commit c286a6e into nrwl:master Jan 30, 2024
6 checks passed
@JamesHenry JamesHenry deleted the fix-21412 branch January 30, 2024 16:59
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linter] 17.3.0 adds new default rules
3 participants