Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): fix expand when using external api #21433

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jan 30, 2024

Current Behavior

the flow is:

  • when page is initialized -> triggers useLayoutChange -> collapse and expand sections based on search params
  • when external api got call -> search params change -> triggers useLayoutChange -> collapse and expand sections based on search params
  • when click on the section -> going to call collapse and expand handler -> setSearchParams -> still triggers useLayoutChange, but should not do anything

remove isExpandedHandled because it prevents external api triggers the useLayoutChange

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 30, 2024 9:14pm

@xiongemi xiongemi force-pushed the feature/nxc-239-repair-auto-expanding-functionality branch 2 times, most recently from 2f4a784 to ad1aa01 Compare January 30, 2024 20:40
@xiongemi xiongemi force-pushed the feature/nxc-239-repair-auto-expanding-functionality branch from ad1aa01 to abc007c Compare January 30, 2024 21:08
@xiongemi xiongemi self-assigned this Jan 30, 2024
Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, thank you :)

@MaxKless MaxKless merged commit a937841 into nrwl:master Jan 31, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
Copy link

github-actions bot commented Feb 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants