Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add missing migration from playwright #21448

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ndcunningham
Copy link
Contributor

This is a follow-up to this previous PR: #21188

The migration is missing so users who were depending on the projects which was removed from @nx/playwright will be broken when they update.

This PR fixes that.

@ndcunningham ndcunningham self-assigned this Jan 30, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner January 30, 2024 22:06
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 7:41pm

@ndcunningham ndcunningham force-pushed the fix/playwright-projects-inline-migrations branch from cccc205 to cebb286 Compare January 31, 2024 16:37
@ndcunningham ndcunningham force-pushed the fix/playwright-projects-inline-migrations branch from cebb286 to a2f27eb Compare January 31, 2024 19:30
@ndcunningham ndcunningham force-pushed the fix/playwright-projects-inline-migrations branch from a2f27eb to 5fd4fae Compare January 31, 2024 19:40
@ndcunningham ndcunningham merged commit 1d87707 into master Jan 31, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/playwright-projects-inline-migrations branch January 31, 2024 20:22
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
Copy link

github-actions bot commented Feb 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants