fix(testing): add support for generating and loading cypress config in ESM format #21471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 663fe44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
approved these changes
Feb 1, 2024
jaysoo
force-pushed
the
fix_cypress_esm
branch
2 times, most recently
from
7dbf299
to
3ccef05
Compare
ndcunningham
approved these changes
Feb 1, 2024
jaysoo
force-pushed
the
fix_cypress_esm
branch
from
3ccef05
to
663fe44
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Cypress configuration generator (
@nx/cypress:configuration) and plugin (@nx/cypress/plugin) so that they support generating and consuming config files in ESM format respectively.There are two issues:
cypress.config.jswithimport/export, which does not work unless the workspace/project hastype: 'module'inpackage.json.require, which does not work with ESM format.Changes:
.tsand.js(ESM) and.js(CJS) formats when generating the cypress config file.importwhen reading cypress config file, which works with both ESM and CJS formats.Current Behavior
ESM format
.jsfiles are brokenExpected Behavior
ESM format
.jsfiles workRelated Issue(s)
Fixes #