Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): replace publish script with nx release config #21474

Merged
merged 71 commits into from Mar 5, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 1, 2024

Current Behavior

The @nx/js:library and create-nx-plugin generators use a custom publish script for publishing packages.

Expected Behavior

The @nx/js:library and create-nx-plugin generators use nx release publish to publish packages.

Additional changes:

  • The @nx/js:library generator now sets "private": true in newly generated package.json files when --publishable is not passed (it already updated existing ones to have "private": true in this case)
  • The nx release version programmatic api now supports generatorOptionsOverrides
  • Nx Release now supports a release.version.preVersionCommand config option that is a command that will be run after validation, but before versioning. This is useful for building artifacts, and is added automatically by the @nx/js:library generator.
  • project-schema.json has been updated to include the release properties
  • Nx Release filters out projects to only those with package.json files by default when no projects config is specified
  • Nx Release filters out projects with "private": true set in package.json by default when no projects config is specified
  • Nx Release no longer errors if some files are ignored by git and committing is enabled.
  • @nx/plugin:e2e-project warns the user if they are not using nx release in their verdaccio setup script

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 9:02pm

@fahslaj fahslaj marked this pull request as ready for review February 1, 2024 03:30
@fahslaj fahslaj requested review from a team as code owners February 1, 2024 03:30
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s discuss on slack

@fahslaj fahslaj marked this pull request as ready for review February 29, 2024 17:11
@fahslaj fahslaj requested a review from a team as a code owner February 29, 2024 17:11
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small comments, nothing major 🎉

e2e/js/src/js-generator-publishable.test.ts Outdated Show resolved Hide resolved
e2e/js/src/js-generator-publishable.test.ts Outdated Show resolved Hide resolved
packages/js/src/generators/library/library.ts Outdated Show resolved Hide resolved
packages/js/src/generators/library/library.ts Show resolved Hide resolved
packages/nx/src/command-line/release/changelog.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/publish.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/release.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/version.ts Outdated Show resolved Hide resolved
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small comments, nothing major 🎉

@FrozenPandaz FrozenPandaz merged commit 38179ad into nrwl:master Mar 5, 2024
6 checks passed
@fahslaj fahslaj deleted the feat/nx-release-in-nxjs-generator branch March 6, 2024 03:17
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants