fix(linter): ensure flat config generator works for pcv3 plugin #21485
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c1e496. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
| (t) => projectConfig.targets[t].executor === '@nx/eslint:lint' | ||
| (t) => | ||
| projectConfig.targets[t].executor === '@nx/eslint:lint' || | ||
| projectConfig.targets[t].command.includes('eslint ') |
There was a problem hiding this comment.
I don't think we want the space here, in v9 (in prerelease now) they have switched it so that eslint works in the current directory with no arguments
There was a problem hiding this comment.
I thought that having just eslint might have some unexpected things caught. But I guess we can solve that once it happens.
| (t) => | ||
| (t === '@nx/eslint:lint' || | ||
| nxJson.targetDefaults[t].executor === '@nx/eslint:lint') && | ||
| nxJson.targetDefaults[t].executor === '@nx/eslint:lint' || | ||
| nxJson.targetDefaults[t].command.includes('eslint ')) && |
(cherry picked from commit c753838)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #