Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add e2e to ci workflows #21487

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Generated workflow has just lint, test and build defined

Expected Behavior

If @nx/cypress or @nx/playwright are detected the workflow will also add e2e

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Feb 1, 2024
@meeroslav meeroslav requested a review from a team as a code owner February 1, 2024 13:40
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 10:14pm

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be looking at @nx/* packages, not @nrwl/*

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) February 2, 2024 22:20
@FrozenPandaz FrozenPandaz merged commit f309b25 into nrwl:master Feb 2, 2024
4 of 6 checks passed
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants