Skip to content

fix(release): skip lock file update if yarn classic #21489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix(release): skip lock file update if yarn classic #21489

merged 3 commits into from
Feb 1, 2024
+53 −6

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 1, 2024 •
edited
Loading

Current Behavior

nx release will try to update the yarn classic lock file with yarn install.

Expected Behavior

nx release will skip the update lock file step and not perform yarn install for yarn classic.

Fixes #21464

@fahslaj
fix(release): don't update lock file if yarn classic

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
2d9533d
@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 1, 2024 5:24pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 1, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 254d0a3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@fahslaj
chore(release): add e2e case for yarn classic

Partially verified

This commit is signed with the committer’s verified signature.
FrozenPandaz’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
286e768
@fahslaj
Merge branch 'master' into fix/no-lockfile-update-if-yarn-1
254d0a3
@fahslaj fahslaj marked this pull request as ready for review February 1, 2024 17:58
@fahslaj fahslaj requested review from a team as code owners February 1, 2024 17:58
@fahslaj fahslaj merged commit f21b86c into nrwl:master Feb 1, 2024
@fahslaj fahslaj deleted the fix/no-lockfile-update-if-yarn-1 branch February 1, 2024 18:02
FrozenPandaz pushed a commit to FrozenPandaz/nx that referenced this pull request Feb 1, 2024
@fahslaj @FrozenPandaz
fix(release): skip lock file update if yarn classic (nrwl#21489)
590cd37
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
@fahslaj @FrozenPandaz
fix(release): skip lock file update if yarn classic (#21489)
10da2b5 
(cherry picked from commit f21b86c)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry

@Cammisuli Cammisuli

@jaysoo jaysoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nx release: allow for version to not update yarn classic lock files by default
2 participants
@fahslaj @JamesHenry