feat(core): add migration to disable adding plugins automatically in existing workspaces #21508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b596e09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/disable-plugins-for-existing-workspaces
branch
4 times, most recently
from
a8875e9
to
ff1f1b4
Compare
…existing workspaces
AgentEnder
force-pushed
the
feat/disable-plugins-for-existing-workspaces
branch
from
ff1f1b4
to
b17f0a7
Compare
FrozenPandaz
requested changes
Feb 2, 2024
packages/nx/src/migrations/update-18-0-0/disable-crystal-for-existing-workspaces.ts
Outdated
Show resolved
Hide resolved
FrozenPandaz
approved these changes
Feb 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Adding inferences plugins by default can have unexpected side effects for users with a customized workspace
Expected Behavior
Existing workspaces must manually enable any plugins they would like, or opt in otherwise.
Related Issue(s)
Fixes #