Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Update Nx Welcome to include nx show project #21509

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

ndcunningham
Copy link
Contributor

Update NxWelcome component to include nx show project { project-name } --web

Sample

Web:
Screenshot 2024-02-01 at 3 57 34 PM

Mobile:
Screenshot 2024-02-01 at 3 56 10 PM

@ndcunningham ndcunningham requested review from a team and Coly010 as code owners February 1, 2024 23:02
@ndcunningham ndcunningham self-assigned this Feb 1, 2024
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 0:26am

@Coly010
Copy link
Contributor

Coly010 commented Feb 1, 2024

We should have the project name in the generator code, and it might already even be passed to generateFiles. I think we should use that such that it shows nx show myapp —web

@ndcunningham ndcunningham force-pushed the fix/nx-welcome-add-show-project-section branch from 1d7dba4 to 4217d63 Compare February 2, 2024 00:18
@ndcunningham ndcunningham enabled auto-merge (squash) February 2, 2024 00:18
@ndcunningham ndcunningham force-pushed the fix/nx-welcome-add-show-project-section branch from 4217d63 to 45bc1da Compare February 2, 2024 00:25
@ndcunningham ndcunningham merged commit ea5befb into master Feb 2, 2024
@ndcunningham ndcunningham deleted the fix/nx-welcome-add-show-project-section branch February 2, 2024 00:45
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
FrozenPandaz pushed a commit that referenced this pull request Feb 3, 2024
Copy link

github-actions bot commented Feb 9, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants