Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): move github release creation to git tasks #21510

Merged
merged 17 commits into from Feb 14, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 2, 2024

Current Behavior

nx release fails when configured to create a github release because the release is created before changes are committed and tagged. This results in duplicate git tags being created and an error.

Expected Behavior

nx release properly creates a github release after committing, tagging, and pushing changes. nx release changelog is unaffected.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 13, 2024 11:35pm

@fahslaj fahslaj marked this pull request as ready for review February 7, 2024 20:36
@fahslaj fahslaj requested review from a team as code owners February 7, 2024 20:36
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The programmatic API example docs need to updated to no longer treat the return value of releaseChangelog as a status code, and @juristr will need to update his recent blog post once this is released

@fahslaj fahslaj merged commit b625a79 into nrwl:master Feb 14, 2024
6 checks passed
@fahslaj fahslaj deleted the fix/release-changelog-fixes branch February 14, 2024 00:32
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants