New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): move github release creation to git tasks #21510
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7021666. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
f07ec57
to
9829ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The programmatic API example docs need to updated to no longer treat the return value of releaseChangelog as a status code, and @juristr will need to update his recent blog post once this is released
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
nx release
fails when configured to create a github release because the release is created before changes are committed and tagged. This results in duplicate git tags being created and an error.Expected Behavior
nx release
properly creates a github release after committing, tagging, and pushing changes.nx release changelog
is unaffected.