Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): setup-ssr generator should not read the graph for a project that doesnt exist #21522

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 2, 2024

Current Behavior

When running host and remote generators with --ssr, the setup-ssr generator tries to read the project graph to get information about these projects.

As the projects have not yet been fully generated, the project graph does not contain these nodes.

Expected Behavior

Attempt to read the projectConfig from project.json before trying to check the graph.

NOTE: There needs to be a way for us to get the project graph for a node that has not been fully generated for cases when a Crystal project is in the process of being generated, will have inferred targets, but a subsequent generator will need information about the config.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 2, 2024 11:52
@Coly010 Coly010 requested a review from jaysoo February 2, 2024 11:52
@Coly010 Coly010 self-assigned this Feb 2, 2024
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 11:59am

@Coly010 Coly010 merged commit da0f06f into nrwl:master Feb 2, 2024
6 checks passed
@Coly010 Coly010 deleted the fix-mf-ssr branch February 2, 2024 14:35
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants