Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix webpack plugin issues and e2e tests #21531

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 2, 2024

This PR fixes the two failing webpack e2e tests One test required two small fixes:

  1. NxWebpackPlugin - Should not override user's config.target with 'web'
  2. @nx/webpack:configuration- Generator had wrong output.path and was nested it under <proj>/dist/<proj> rather than dist/<proj>.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner February 2, 2024 14:44
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 4:00pm

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, just one comment

@jaysoo jaysoo enabled auto-merge (squash) February 2, 2024 16:11
@jaysoo jaysoo merged commit e85f700 into nrwl:master Feb 2, 2024
6 checks passed
@jaysoo jaysoo deleted the fix_webpack branch February 2, 2024 16:31
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants