fix(core): remove the full workspace path with node_modules from the path env variable when running run-scripts
#21532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5e5d1d2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
previously requested changes
Feb 2, 2024
Cammisuli
force-pushed
the
remove_node_modules_from_path
branch
from
13adcab
to
deffeab
Compare
…path env variable when running `run-scripts`
Cammisuli
force-pushed
the
remove_node_modules_from_path
branch
from
deffeab
to
5e5d1d2
Compare
FrozenPandaz
approved these changes
Feb 2, 2024
FrozenPandaz
dismissed
AgentEnder’s stale review
It's path.delimiter but it was addressed
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running nx through npx (and only npx when node_modules is installed with npm) that executes a script command, the exit code will always be 0.
Expected Behavior
Running nx through npx should propagate the correct error code
Related Issue(s)
Fixes #21506