Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nest): ensure dependencies are installed when generating nest libraries #21534

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 2, 2024

When a Node lib is generated without an app, we don't ensure that dependencies are installed. This PR adds those installs to the lib generator.

In practice, this should not happen since the workspace must have an app if it is adding a lib, but for correctness we need the ensure.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team as code owners February 2, 2024 15:12
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 3:19pm

e2e/node/src/node.test.ts Outdated Show resolved Hide resolved
@jaysoo jaysoo changed the title Fix nest fix(nest): ensure dependencies are installed when generating nest libraries Feb 2, 2024
@jaysoo jaysoo enabled auto-merge (squash) February 2, 2024 15:28
@jaysoo jaysoo merged commit 3ec71fa into nrwl:master Feb 2, 2024
6 checks passed
@jaysoo jaysoo deleted the fix_nest branch February 2, 2024 15:58
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants