fix(react): app generator should handle crystal workspaces #21537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5743a75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
remix/crystal-support
branch
from
9350f95
to
cf7e147
Compare
Coly010
force-pushed
the
remix/crystal-support
branch
from
cf7e147
to
bd46ba8
Compare
Coly010
force-pushed
the
remix/crystal-support
branch
from
bd46ba8
to
269e954
Compare
Coly010
force-pushed
the
remix/crystal-support
branch
from
269e954
to
5743a75
Compare
jaysoo
approved these changes
Feb 2, 2024
isaacplmann
approved these changes
Feb 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The remix app generator was always adding targets to the project.json, even in crystal workspaces
Expected Behavior
Do not add targets to project.json in crystal workspaces
Related Issue(s)
Fixes #