Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): target defaults from specifier should not be clobbered by name based target defaults #21539

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

Its possible for a target default defined as "build" to overwrite the defaults defined by "@nx/js:tsc".

Expected Behavior

Executor based defaults have priority

Related Issue(s)

Fixes #21526
Fixes #21477

@AgentEnder AgentEnder requested a review from a team as a code owner February 2, 2024 16:02
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 4:03pm

@FrozenPandaz FrozenPandaz merged commit 4a5a92f into nrwl:master Feb 2, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 2, 2024
…name based target defaults (#21539)

(cherry picked from commit 4a5a92f)
FrozenPandaz pushed a commit that referenced this pull request Feb 3, 2024
…name based target defaults (#21539)

(cherry picked from commit 4a5a92f)
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants