fix(devkit): respect expectComments when parsing json #21584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 29298ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
[This change](https://github.com/nrwl/nx/pull/10538/files#diff-7f0343ab5195423aded5b2ed7b98cef5fd459edbb66227eb67f0c0fa25eaf3a4L40-L50) introduced a small performance regression by removing the check for the `expectComments` flag.
|
@FrozenPandaz Do you need an issue for this? Or is a PR sufficient? |
4 tasks
AgentEnder
approved these changes
Feb 22, 2024
jaysoo
pushed a commit
that referenced
this pull request
Feb 23, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduced a small performance regression by removing the check for the
expectCommentsflag.Current Behavior
Passing
expectCommentstoparseJsondoes nothing.Expected Behavior
Passing
expectCommentstoparseJsonshould bypass the optimisticJSON.parsesince in those cases it is expected to fail.Related Issue(s)