Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): require ForkTsCheckerWebpackPlugin only as required #21629

Merged
merged 1 commit into from Feb 5, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 5, 2024

There is an issue when ForkTsCheckerWebpackPlugin is required, it then calls require('process') which messes up SIGINT, etc. for child processes running through Rust.

This change mitigates the issue, which we will still fix in a subsequent PR.

Current Behavior

On some environments ^C cannot kill the Nx process.

Expected Behavior

^C should work.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 10:05pm

@jaysoo jaysoo marked this pull request as ready for review February 5, 2024 22:04
@jaysoo jaysoo requested a review from a team as a code owner February 5, 2024 22:04
@jaysoo jaysoo requested a review from mandarini February 5, 2024 22:04
@FrozenPandaz FrozenPandaz merged commit bf62661 into nrwl:master Feb 5, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 5, 2024
@jaysoo jaysoo deleted the webpack_fix branch February 6, 2024 03:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants