fix(core): handle blocking stdin #21672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ba4bcb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
Cammisuli
commented
Feb 7, 2024
Cammisuli
force-pushed
the
handle_blocking_stdin
branch
from
a5ed272
to
d29e950
Compare
Cammisuli
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
FrozenPandaz
approved these changes
Feb 7, 2024
Cammisuli
force-pushed
the
handle_blocking_stdin
branch
from
09fb118
to
9ba4bcb
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 7, 2024
(cherry picked from commit 1dd3637)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When stdin is being used by another process, we silently fail and all stdin will be ignored
Expected Behavior
We now register with a polling system that will allow us to check when stdin is available and used.
Related Issue(s)
Fixes #21523