Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): temporary use forked portable_pty to inherit cursor position for windows #21683

Merged
merged 2 commits into from Feb 7, 2024

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Feb 7, 2024

Current Behavior

Some output on Windows becomes mangled because of ANSI codes that the Conpty adds.

Expected Behavior

Uses a forked portable_pty library to set the position of the cursor to inherit so that destructive ansi codes are not added.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 7:49pm

@Cammisuli Cammisuli marked this pull request as ready for review February 7, 2024 19:52
@FrozenPandaz FrozenPandaz merged commit e0d8eab into nrwl:master Feb 7, 2024
4 of 6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 7, 2024
@Cammisuli Cammisuli deleted the use-temp-portable-pty branch February 7, 2024 23:58
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants