Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): import esbuild before loading config to keep it in cache #21685

Merged
merged 1 commit into from Feb 7, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 7, 2024

This is a workaround for the build$3 error from Vite when the esbuild module loaded from ESM exports nothing.

We're trying this patch temporarily to work around an issue during resolveConfig call from vite package.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 8:21pm

@jaysoo jaysoo marked this pull request as ready for review February 7, 2024 20:20
@jaysoo jaysoo requested a review from a team as a code owner February 7, 2024 20:20
@jaysoo jaysoo closed this Feb 7, 2024
@jaysoo jaysoo reopened this Feb 7, 2024
@FrozenPandaz FrozenPandaz merged commit db8b37f into nrwl:master Feb 7, 2024
5 of 7 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 7, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants