Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): use --first-parent to support merged repos #21686

Merged
merged 4 commits into from Feb 13, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 7, 2024

Related Issue(s)

Fixes #21649

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 12, 2024 4:28pm

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually on second look, is that correct?

You have HEAD as a positional twice it looks like?

@fahslaj
Copy link
Contributor Author

fahslaj commented Feb 8, 2024

Actually on second look, is that correct?

You have HEAD as a positional twice it looks like?

The second HEAD is the value being passed for --first-parent. I can use "=" to make it more explicit though.

EDIT: It seems to error when using --first-parent=HEAD. Looks like it is redundant. I've removed it.

@JamesHenry JamesHenry merged commit a045b3f into nrwl:master Feb 13, 2024
6 checks passed
@fahslaj fahslaj deleted the fix/21649-fix-rev-parse branch February 13, 2024 14:21
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx release --first-release crashes when 2 git repos were merged
2 participants