Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): logging improvements #21692

Merged
merged 2 commits into from Feb 8, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 7, 2024

Current Behavior

  • nx release logs do not consistently use the Nx output logger
  • nx release prints duplicate dry run messages
  • nx release does not exit when ctrl+c is pressed on the github release recovery step

Expected Behavior

  • nx release logs consistently use the Nx output logger
  • nx release prints a single dry run message at the end of the execution
  • nx release does exits with code 1 when ctrl+c is pressed on the github release recovery step

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 11:23pm

@fahslaj fahslaj marked this pull request as ready for review February 8, 2024 00:32
@fahslaj fahslaj requested a review from a team as a code owner February 8, 2024 00:32
@JamesHenry JamesHenry merged commit 49bba42 into nrwl:master Feb 8, 2024
6 checks passed
@fahslaj fahslaj deleted the fix/nx-release-logging-improvements branch February 8, 2024 15:27
FrozenPandaz pushed a commit that referenced this pull request Feb 9, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants