fix(js): nx release-version resolve-version-spec should normalize fetchSpec #21710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 75082ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
fix/nx-release-file-versions
branch
from
891ccf5
to
03ac573
Compare
JamesHenry
approved these changes
Feb 8, 2024
Coly010
force-pushed
the
fix/nx-release-file-versions
branch
from
c4300b8
to
bdeb153
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We use
npm-package-argto resolve thefetchSpecfor packages. It will return OS-specific paths.When we try to compare that to the local workspace packages'
targetPackage.location, it fails to match, as one path is win-style and the other is unix-style.This causes issue on Windows for updating the versions of local packages.
Expected Behavior
Normalize the
fetchSpecif it is a path, and if it is a win-style path.Related Issue(s)
Fixes #