fix(testing): increase the default timeout to 15s for the dev server to start #21716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 21a471a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
Feb 8, 2024
AgentEnder
approved these changes
Feb 8, 2024
leosvelperez
force-pushed
the
cypress/increase-dev-server-waiting-timeout
branch
from
950b980
to
21a471a
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The default timeout for waiting for the dev server started by the Cypress preset is 10s. This default timeout seems a bit low and some of our e2e test cases (not big apps or doing anything crazy) sometimes fail due to taking a bit longer.
Expected Behavior
The default timeout for waiting for the dev server started by the Cypress preset should be a bit higher to cover more apps by default and without the need to configure the timeout.
Related Issue(s)
Fixes #